Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Awaits the promises returned by
root.unmountto avoid potential race conditions leading to memory leak bugs. This fix may have detrimental impacts depending on how longskiaReconciler.updateContainertakes, but I believe that memory safety and reliability are more important.Context
This pull request attempts to fix memory leaks reported in #3769. We've been testing this fix (amongst others) in production for the past 12 hours. So far, we haven't seen any memory issues since deploying.
Additional Notes
There's one
useEffectinCanvas.tsxin which theroot.unmountwasn't changed and is left unawaited. This is pretty standard for useEffects, but may be worth investigating to make sure there's no risk for memory leak race conditions there.