Skip to content

Support annotations in HTTPRoute#794

Open
Brawdunoir wants to merge 3 commits intoSonarSource:masterfrom
AvistoTelecom:master
Open

Support annotations in HTTPRoute#794
Brawdunoir wants to merge 3 commits intoSonarSource:masterfrom
AvistoTelecom:master

Conversation

@Brawdunoir
Copy link
Copy Markdown

Motivation

Most external tools (like external-dns or cert-manager) rely on annotations instead of labels. Currently, only labels can be set while using the chart, which limit the interaction with external tools.

Please ensure your pull request adheres to the following guidelines:

  • explain your motives to contribute this change: what problem you are trying to fix, what improvement you are trying to make
  • Document your Changes in the CHANGELOG.md file of the respected chart as well as the Chart.yaml

@jimil09 jimil09 requested review from jimil09 April 2, 2026 13:18
@jimil09
Copy link
Copy Markdown
Contributor

jimil09 commented Apr 2, 2026

Hi @Brawdunoir!

Many thanks for your PR. The changes look fine, but before I test, could you please rebase on the latest master, resolve the conflicts and push again?

@Brawdunoir Brawdunoir reopened this Apr 2, 2026
@Brawdunoir
Copy link
Copy Markdown
Author

Hello @jimil09, done !

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Clean, minimal PR that correctly adds annotation support to HTTPRoute. No bugs or logic issues found.

🗣️ Give feedback

Copy link
Copy Markdown
Contributor

@jimil09 jimil09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Brawdunoir! 👋

Thanks for submitting this PR; the feature makes sense and the implementation looks good! I have a few suggestions to make this complete:

1. sonarqube-dce Chart

The sonarqube-dce (Data Center Edition) chart also has HTTPRoute support but wasn't updated in this PR. Since both charts should maintain feature parity, could you please add the same annotation support to:

  • charts/sonarqube-dce/templates/http-route.yaml (add annotations block)
  • charts/sonarqube-dce/values.yaml (add commented example)
  • charts/sonarqube-dce/CHANGELOG.md (add entry)

2. CHANGELOG Version

The CHANGELOG entry was added to [2026.2.0], but since that version has already been released, this should be moved to the upcoming [2026.3.0] section

3. Chart.yaml Metadata

Could you also add an entry to the artifacthub.io/changes annotation in both charts/sonarqube/Chart.yaml and charts/sonarqube-dce/Chart.yaml? Something like:

artifacthub.io/changes: |
  - kind: added
    description: "Support annotations in HTTPRoute"

@jimil09 jimil09 assigned jimil09 and unassigned jimil09 Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants