Add Deck Shelves to Plugin Store#1018
Add Deck Shelves to Plugin Store#1018santojon wants to merge 18 commits intoSteamDeckHomebrew:mainfrom
Conversation
Issues Found
Next Steps
Thank you for your contribution! If you need any help, please reach out on our Discord server. ❤️ |
|
debug flag exists on code just for debug purposes, but is removed in my packaging script: if have to run this script on some specific flow decky build follows, please say me I'm using it on and |
|
Hi, 1- My favorites aren't displaying. I have 7 favorites, but nothing shows up on the home screen. Perhaps the selection is based on the collection name, which in my case must be French and in yours English? So the problem would occur for all languages. 2- I tried the "Recently Added" collection, but it doesn't seem to be sorted in that order. 3- The displayed covers don't use the style (rounded edges, for example). You can see that when I navigate, Steam games have a border radius when focused, but not the Steam games themselves (Cyberpunk 2077 is a non-steam game, Splitgate is a steam game). 4- When navigating the Steam row, the focus of the game I'm browsing is the middle one. If I scroll to the right, it scrolls to the left, but the selected cover is still the middle one. With your plugin, the selection goes all the way to the right before scrolling. 5- There's a sort of lag, more like a latency (but I don't know if it's Steam causing this or not) when I navigate to a line you added 6- Quite a few translations are missing Despite these points, the plugin is really clean and works very well. I expected some asynchronous loading with a delay before collections appeared, but that’s not the case. |
|
@moi952 Please only review plugins that have been deployed to the testing store. Withholding review on this plugin since the required action mentioned by GitHub Actions has not been completed. |
Sorry, I didn't know. This is the first time I've submitted a plugin, and especially the first time I've seen how it works overall. |
Our build CI just builds from the source that is in the file at present, so you will have to remove the debug flag in source. Additionally, it appears you have not properly linked the submodule as there is no new plugins being detected. |
|
@santojon Please make your submodule a path without spaces. |
Unless you use the backend folder to run a custom backend build process, you can't easily specify a shell script to run. I highly recommend removing the debug flag and using a shell script to build it with the flag instead. |
Both suggestions done ✅ @EMERALD0874 |
a3f7893 to
d45d7ea
Compare
Have tried here and now it seems to be ok. Can you try again? |
1eb20a3 to
e79ca05
Compare
|
@santojon, Please refrain from making a large number of updates to your PR while it's still in the review stage. When you feel your plugin is feature-complete for a first release, please reply and let me know and then we will review it, but any further updates would cause us to have to start from scratch reviewing it. |
@beebls The main features are ready. I was just taking advantage of the fact that it hasn't been approved yet to add improvements. In that case, I'll stop updating from now until it's approved. |


Add Deck Shelves to Plugin Store
Features
library/homeTask Checklist
Developer
Plugin
Backend
Community
Testing