Skip to content

Fix simplex max iteration failure and optimize pivot operation#14587

Closed
MeriemBchini wants to merge 4 commits intoTheAlgorithms:masterfrom
MeriemBchini:simplex-final-fix
Closed

Fix simplex max iteration failure and optimize pivot operation#14587
MeriemBchini wants to merge 4 commits intoTheAlgorithms:masterfrom
MeriemBchini:simplex-final-fix

Conversation

@MeriemBchini
Copy link
Copy Markdown

Summary

This PR improves both correctness and performance of the simplex algorithm implementation.

Previously, run_simplex() silently returned an empty dictionary when the maximum iteration limit was reached, making failures hard to detect and debug.

This update introduces explicit error handling and optimizes the pivot operation for better performance.


Changes

  • Replaced silent failure (return {}) with a descriptive ValueError when maximum iterations are exceeded
  • Added iteration tracking for clearer debugging information
  • Optimized pivot operation using NumPy vectorization (removes Python loop)
  • Improved type safety and removed unsafe typing patterns
  • Fixed minor code quality and style issues to align with repository standards

Why this matters

This change improves:

  • Correctness: failures are now explicit instead of silent
  • Debuggability: users get clear error messages when convergence fails
  • Performance: pivot step is now vectorized, reducing runtime overhead on large tableaus
  • Maintainability: cleaner and more readable implementation

Behavior Change

Before:

run_simplex() → {}

After:

Raises:

MeriemBchini and others added 4 commits April 26, 2026 19:59
- Replaced silent failure with ValueError on max iteration
- Vectorized pivot step using NumPy for performance improvement
- Improved clarity and robustness of simplex implementation
@algorithms-keeper
Copy link
Copy Markdown

Closing this pull request as invalid

@MeriemBchini, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed invalid labels Apr 26, 2026
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant