Backend: Basic plumbing for bookmark feature#4308
Draft
ChargrilledChook wants to merge 3 commits intomainfrom
Draft
Backend: Basic plumbing for bookmark feature#4308ChargrilledChook wants to merge 3 commits intomainfrom
ChargrilledChook wants to merge 3 commits intomainfrom
Conversation
ChargrilledChook
commented
Jan 3, 2024
| <div class="flex items-center justify-center" id="bookmark-button"> | ||
| <%= button_to create_or_destroy_path, | ||
| form_class: 'w-full h-full', | ||
| method: bookmarked? ? :delete : :post, |
Member
Author
There was a problem hiding this comment.
Would have preferred to keep the logic in the VC class with the rest of it, but putting it in a method didn't work for some reason 🤷
3 tasks
* Add basic bookmark component * Add routes * Add title delegator to bookmark model * Add basic bookmark controller * Add bookmark to lessons controller * Add first pass basic bookmark button component * Placeholder basic bookmark index page * Add bookmark component to lesson buttons * Get button working roughly with turbo stream
ChargrilledChook
force-pushed
the
feature/lesson-bookmarks
branch
from
7733e4f to
64b018a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A (very rough) spike for a lesson bookmarking feature to gain feedback on whether it's valuable and worth polishing.
Would need more thought around design, UI and UX. Ideally bookmarks would live on the existing dashboard. Would need to consider other technical limitations too (should users only be able to bookmark n lessons? If yes, how does adding and removing look at the limit?)
But before needing to answer all those questions, we can get test the waters and see if there's any appetite for this
Notes:
bookmarksfeature flagTodo: