Conversation
issue #6 initial review
Sb issue read me
There was a problem hiding this comment.
Pull request overview
This PR completes the “Sandbox” cookie manager demo by adding cookie grouping support, implementing cookie/group deletion attempts, and updating the demo app + documentation to reflect the new configuration options.
Changes:
- Reworked the cookie manager UI to render cookies grouped under collapsible sections, with per-cookie and per-group delete actions.
- Added group-rules synchronization/validation logic plus cookie deletion attempts (including parent-domain attempts) in the element implementation.
- Updated demo app wiring, dev server script, and README instructions/usage examples.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/elements/cork-cookie-manager.tpl.js | New grouped “grid” UI layout, group header + delete-group button, dev-only test cookie button |
| src/elements/cork-cookie-manager.js | Group rules syncing/validation, cookie grouping, cookie & group deletion logic, dev-only test cookie generation |
| app/public/elements/demo-main.tpl.js | Demo now imports exported rules and renders them; passes group rules into <cork-cookie-manager> |
| app/public/elements/demo-main.js | Adds demo groupRules configuration used by the template |
| app/package.json | Switches demo serve script to node server.js |
| README.md | Updates local dev steps and adds usage/config documentation (group rules + parent domain) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| <!-- Body Rows --> | ||
| ${cookies.map(cookie => html` | ||
| <div class="grid-row" role="row"> |
There was a problem hiding this comment.
i'm just looking at your code and have not tested it, but make sure your element looks good on a very small screen (especially with a long cookie name). This is where a "table-like" layout typically fails.
Completed functionality