fix: NullReferenceException when non-member joins channel via SignalR#1530
Open
kuu-26 wants to merge 1 commit intoValour-Software:mainfrom
Open
fix: NullReferenceException when non-member joins channel via SignalR#1530kuu-26 wants to merge 1 commit intoValour-Software:mainfrom
kuu-26 wants to merge 1 commit intoValour-Software:mainfrom
Conversation
The JoinChannel hub method was calling .ToModel() on a potentially null PlanetMember result from FirstOrDefaultAsync(). When a user who is not a member of the planet tries to join a channel, this caused a NullReferenceException that propagated all the way through PlanetPermissionService.GetChannelPermissionsAsync. Fix: Check for null dbMember before calling .ToModel() and return an appropriate error message. Fixes VALOUR-BACKEND-2W (254 events, 30 users affected)
SpikeViper
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JoinChannel hub method was calling .ToModel() on a potentially null PlanetMember result from FirstOrDefaultAsync(). When a user who is not a member of the planet tries to join a channel, this caused a NullReferenceException that propagated all the way through PlanetPermissionService.GetChannelPermissionsAsync.
Fix: Check for null dbMember before calling .ToModel() and return an appropriate error message.
Fixes VALOUR-BACKEND-2W (254 events, 30 users affected)