fix: prevent double-submit on upload and handle DB race on cdn insert#1535
Merged
SpikeViper merged 1 commit intoValour-Software:mainfrom Apr 18, 2026
Merged
Conversation
|
For reference: fixes #1370. |
SpikeViper
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related fixes for the upload flow:
1. Client: FileUploadComponent double-submit guard
The Upload button and Enter key had no guard against double-firing. Added
_isUploadingflag that blocks repeated clicks and disables the button during upload.2. Server: CdnBucketService race condition handling
The check-then-insert pattern (AnyAsync → AddAsync → SaveChangesAsync) has a TOCTOU race under concurrent uploads. Both requests pass the AnyAsync check, both try to insert, one gets a DbUpdateException on the PK. The old code caught generic Exception and logged it as an error even though it was a harmless duplicate.
Changes:
This should eliminate the Sentry alerts for VALOUR-BACKEND-2B (Failed DbCommand INSERT into cdn_bucket_items) while keeping the upload flow working correctly.