Fix build and tests for wasm32-wasip2 target#599
Merged
alexcrichton merged 1 commit intoWebAssembly:mainfrom Jul 29, 2025
Merged
Fix build and tests for wasm32-wasip2 target#599alexcrichton merged 1 commit intoWebAssembly:mainfrom
alexcrichton merged 1 commit intoWebAssembly:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to build wasi-libc for the
wasm32-wasip2target and run the tests, I noticed a few issues:TARGET_TRIPLEwas being used before definition, in the definition ofOBJDIR.TARGET_TRIPLEtowasm32-wasip2.This always left the target as
wasm32-wasi, since it was defined to that in a previous line.builtinswasn't being built by default, so building the tests would fail because it was unable to findlibclang_rt.builtins.a.make testdidn't take theWASI_SNAPSHOTvariable into consideration.clang --target=wasm32-wasip2was building a P2 component,which caused the subsequent
wasm-tools component newto fail because the inputwas already a component.
This PR fixes these issues. Now I'm able to run the tests with
WASI_SNAPSHOT=p2.