Skip to content

Adjustments to allow for theme to build on Windows#86

Open
daveromsey wants to merge 3 commits intomainfrom
bug/windows-build-fix-2026-04-10
Open

Adjustments to allow for theme to build on Windows#86
daveromsey wants to merge 3 commits intomainfrom
bug/windows-build-fix-2026-04-10

Conversation

@daveromsey
Copy link
Copy Markdown

@daveromsey daveromsey commented Apr 15, 2026

Closes https://app.clickup.com/t/9011385391/WDSBT-299

Link to test

N/a - Test locally on Windows/Linux

Description

While working on https://app.clickup.com/t/9011385391/WDSBT-298, I found that I was unable to build BT on Windows on a Local install. I also tested using the Dev Container supplied by BT, but the build failed there too.

I used Cursor to create the fix in this branch. I'm not super sure that this is the best approach, but it did allow for the theme to build.

Related Tickets & Documents

https://app.clickup.com/t/9011385391/WDSBT-299
https://app.clickup.com/t/9011385391/WDSBT-298

Mobile & Desktop Screenshots/Recordings

Success!
image

AI Assistance

  • 🤖 This project was developed with the help of a LLM/AI such as Cursor, Gemini, etc.

Added to documentation?

  • 📜 README.md
  • 📓 ClickUp
  • 🙅 No documentation needed

Added tests?

  • 👍 Yes
  • 🙅 No, because they aren't needed
  • 🙋 No, because I need help

Testing Instructions


Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

@daveromsey daveromsey requested a review from khleomix as a code owner April 15, 2026 20:36
@thatmitchcanter
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Contributor

@khleomix khleomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daveromsey please fix errors and send back for re-review. Thanks!

@khleomix khleomix self-requested a review April 27, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants