feat: test resubscription to the task#535
Merged
kdziedzic70 merged 1 commit intoimplement-itk-servicefrom May 4, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a 'resubscribe' behavior across Go and Python agents, allowing tasks to be held in a working state for later retrieval. It adds a 'hold_task' field to the protobuf definitions and implements periodic status updates. Review feedback suggests restoring commented-out task enrollment in the Python v03 agent, re-enabling the full integration test suite, correcting a recurring typo in the 'task-finnished' sentinel string, and optimizing JSON imports in the test library.
kdziedzic70
changed the title
kdziedzic70
force-pushed
the
feat/test-task-resubscribing
branch
17 times, most recently
from
cef7204 to
cec44ac
Compare
kdziedzic70
changed the title
| if call.Streaming { | ||
| if call.GetResubscribe() != nil { | ||
| return e.handleCallAgentWithResubscribe(ctx, client, wrappedMsg, call.AgentCardUri) | ||
| } else if call.Streaming { |
There was a problem hiding this comment.
Suggested change
| } else if call.Streaming { | |
| if call.Streaming { |
kdziedzic70
force-pushed
the
feat/test-task-resubscribing
branch
2 times, most recently
from
96057f7 to
8069d81
Compare
kdziedzic70
force-pushed
the
feat/test-task-resubscribing
branch
from
8069d81 to
6af8df7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.Fixes #<issue_number_goes_here> 🦕