Add mypy.stubtest#92
Merged
Merged
Conversation
abelcheung
added
enhancement
Owner
|
Thanks, this can come in handy. However, although most errors emitted by |
Contributor
Author
|
sounds good!
…On Fri, May 2, 2025, 12:31 AM Abel Cheung ***@***.***> wrote:
*abelcheung* left a comment (abelcheung/types-lxml#92)
<#92 (comment)>
Thanks, this can come in handy. However, although most errors emitted by
mypy.stubtest are dummy, I suspect there is genuine error hidden in
between that needs fixing. So I'd like to have a review personally with all
mypy.stubtest complaints, then merge this PR with a trimmed down
allowlist. That could take some time, so will leave this PR open for a
while when I'm working on it.
—
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPWJFA3OHV5FTGSCJTH7S324MNNXAVCNFSM6AAAAAB4JFV7MWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNBWGU2TOOBWHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
github-project-automation
Bot
moved this from Backlog
to Done
in Migration of types-lxml runtime tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds running
mypy.stubtestalong side the pytest tests that are being run. It can be helpful in comparing typed interfaces with runtime as well as providing context for missing stubs.The allowlist in this PR represents the list of technically missing or deviating variables or modules. Some may be intentional or desirable, but in other cases it could point to gaps in the project.