Updated dependencies#1502
Merged
Merged
Conversation
The shared setConsentHandler had two issues that caused queueTimeMillis.spec.js's "reflects time waiting for consent" test to time out: - Its URL regex required a literal /ee/v1/, so once a prior test in the same file populated the kndctr cluster cookie, the location- hint segment broke matching. Allow an optional segment between /ee/ and /v1/, matching the working handler in consent_gate.spec.js. - It returned an empty handle array, so alloy never received a state:store directive to set the consent cookie. The Consent component reads consent state from the cookie after the request resolves, leaving queued events suspended forever. Return a state:store payload that sets general=in. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Fix new lint errors from preserve-caught-error and no-useless-assignment rules introduced in eslint v10.
Override lodash, minimatch (in jshint), underscore, and yaml to patched versions to address GHSA advisories from deep transitive deps.
- Set rootDir to ".." in browser jsconfig.json so cross-package paths (../core/src/*) resolve under TS 6's stricter rootDir checks. - Refactor serviceWorkerPushListener.js to build NotificationOptions via a typed Record with conditional property assignment, satisfying the stricter exactOptionalPropertyTypes-style narrowing in TS 6. - Update bundlesize snapshot. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
dompuiu
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed Packages
(Also touches
@adobe/alloybrowser package,@adobe/alloy-node, andsandboxes/browser.)Description
Bumps dev and transitive dependencies across the monorepo, then resolves the resulting build/lint/test breakages. Commits are kept small and atomic for easy review (one dependency or coordinated group per commit).
Notable updates:
rootDirenforcement; see fix below).@eslint/js10 (new rules:preserve-caught-error,no-useless-assignment).sandboxes/browser, with@vitejs/plugin-react→ 6.0.1.@rollup/plugin-commonjs→ 29.0.2,@rollup/plugin-terser→ 1.0.0,rollup-plugin-license→ 3.7.1.lodash,minimatch(via jshint),underscore, andyaml.Source/config fixes required by the bumps:
packages/browser/jsconfig.json: explicit"rootDir": ".."sopathsreferring to../core/src/*keep resolving under TS 6's stricterrootDirchecks (TS5011).packages/browser/src/components/PushNotifications/helpers/serviceWorkerPushListener.js: refactorNotificationOptionsconstruction via aRecord<string, unknown>with conditional property assignment to satisfy TS 6's narrowing.packages/core/src/core/buildAndValidateConfig.js,validateCommandOptions.js: attach the original error viacause(ESLint 10preserve-caught-error).packages/core/src/utils/createDecodeKndctrCookie.js: drop a dead assignment caught byno-useless-assignment.Related Issue
N/A — routine maintenance / vulnerability cleanup.
Motivation and Context
Several dev dependencies had outstanding security advisories (rollup path traversal, react-router XSS, transitive lodash/yaml/underscore/minimatch issues). Pulling everything forward also unblocks Vitest 4 / MSW 2.14 features and gets us off the EOL TypeScript 5 line.
Screenshots (if appropriate):
N/A.
Documentation
N/A — no consumer-facing API change.
Types of changes
Checklist:
pnpm test: 2671 passed, 5 skipped, 0 failed;pnpm buildsucceeds across all packages.)Note
Stacked on top of #1501 (test fixture fix needed for the suite to pass). Once that merges, this PR's base will retarget to
main.🤖 Generated with Claude Code