feat(optel): add time-to-submit facet for form submission tracking#304
Open
vdua wants to merge 3 commits into
Open
feat(optel): add time-to-submit facet for form submission tracking#304vdua wants to merge 3 commits into
vdua wants to merge 3 commits into
Conversation
Ports the time-to-submit feature from helix-website: adds formatTimeToMMSS and timeToSubmit helpers, a formsubmit.time facet, and a histogram facet (formsubmit.histogram) showing submission time distribution in mm:ss buckets. Also fixes malformed help-link HTML in explorer.html and adds numeric sorting for histogram facets in list-facet.js. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: vdua <vdua@adobe.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: vdua <vdua@adobe.com>
|
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: vdua <vdua@adobe.com>
Contributor
Code ReviewNo issues found. Checked for bugs and CLAUDE.md compliance. Reviewed:
Verdict: APPROVE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatTimeToMMSS()andtimeToSubmit()helpers toslicer.jsto compute the delta between aviewblockandformsubmitcheckpointformsubmit.timefacet and aformsubmit.histogramhistogram facet (0–600s, 10 quantile buckets, mm:ss labels)explorer.html(attributes were on the<list-facet>element instead of inside an<a>child)formsubmit.histogramfacet entry toexplorer.htmlsort="asc"numeric sorting inlist-facet.jsso histogram bucket labels like"00:10 - 00:30"sort correctlyPreview
https://time-to-submit--helix-tools-website--adobe.aem.page/tools/optel/oversight/explorer.html
Test plan
checkpoint=formsubmitForm Submit Time (mm:ss)histogram facet appears in the sidebarmm:ss🤖 Generated with Claude Code