Skip to content

fix(core): Check whether process is defined before trying to use it#6250

Open
Goodwine wants to merge 2 commits into
adobe:mainfrom
Goodwine:main
Open

fix(core): Check whether process is defined before trying to use it#6250
Goodwine wants to merge 2 commits into
adobe:mainfrom
Goodwine:main

Conversation

@Goodwine
Copy link
Copy Markdown

@Goodwine Goodwine commented May 7, 2026

process does not exist in a browser

Description

Checks for the ambient process being defined before attempting to use it. This is because process is not defined in a browser context.

Motivation and context

This change broke Sass playground

Related issue(s)

Fixes #6242

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • [n/a] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • [n/a] I have added automated tests to cover my changes.
  • [?] I have included a well-written changeset if my change needs to be published.
  • [n/a] I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

N/A

Device review

N/A, but I patched it in the sass-site repo, and it solved the issue.

Accessibility testing checklist

N/A

@Goodwine Goodwine requested a review from a team as a code owner May 7, 2026 21:31
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2026

⚠️ No Changeset found

Latest commit: 43fa037

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Rajdeepc

This comment was marked as outdated.

@Rajdeepc Rajdeepc added Contribution PRs from contributors Status:Ready for review PR ready for review or re-review. labels May 8, 2026
Copy link
Copy Markdown
Contributor

@Rajdeepc Rajdeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check why the tests are failing. Once they are good this is a good additon.

@rubencarvalho
Copy link
Copy Markdown
Contributor

Maybe it is worth checking if it is fixed on the upcoming 1.12.0, as we cut the core dependency which I believe was the origin of this error.

@Goodwine
Copy link
Copy Markdown
Author

I'm actually not sure that the errors are related to the PR. I'll be unavailable for a couple of weeks, but I can look into afterwards.

If you want to take over this, that would be cool too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution PRs from contributors Status:Ready for review PR ready for review or re-review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Uncaught ReferenceError: process is not defined in Base.ts

3 participants