fix(core): Check whether process is defined before trying to use it#6250
fix(core): Check whether process is defined before trying to use it#6250Goodwine wants to merge 2 commits into
process is defined before trying to use it#6250Conversation
`process` does not exist in a browser
|
Rajdeepc
left a comment
There was a problem hiding this comment.
Please check why the tests are failing. Once they are good this is a good additon.
|
Maybe it is worth checking if it is fixed on the upcoming |
|
I'm actually not sure that the errors are related to the PR. I'll be unavailable for a couple of weeks, but I can look into afterwards. If you want to take over this, that would be cool too |
processdoes not exist in a browserDescription
Checks for the ambient
processbeing defined before attempting to use it. This is becauseprocessis not defined in a browser context.Motivation and context
This change broke Sass playground
Related issue(s)
Fixes #6242
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
N/A
Device review
N/A, but I patched it in the
sass-siterepo, and it solved the issue.Accessibility testing checklist
N/A