docs(swc): rework CHANGELOG for 2.0.0-beta1 initial release#6266
docs(swc): rework CHANGELOG for 2.0.0-beta1 initial release#6266rubencarvalho wants to merge 5 commits into
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Replace the 0.0.x pre-release history in @adobe/spectrum-wc's CHANGELOG with a single 2.0.0-beta1 section listing one entry per component shipping in the initial public release (button, avatar, badge, divider, illustrated-message, progress-circle, status-light, tabs, typography) plus the new Conversational AI pattern. Each entry is a one-liner with links to the component docs and the consumer migration guide.
8d15b0e to
d1d85d5
Compare
Establish a unified changelog format for @adobe/spectrum-wc where changeset bodies flow verbatim into the CHANGELOG — no commit hashes, no author attributions, no reformatting. - Add scripts/changelog-passthrough.cjs: hybrid changelog function that passes through entries for 2nd-gen and delegates to @changesets/changelog-github for 1st-gen - Update .changeset/config.json to use the passthrough script - Add contributor guide (15_changelog-strategy.md) with format spec - Add strategy proposal doc for team review - Cross-link from PR guide and release guide Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…om 2nd-gen CHANGELOGs The changesets library hardcodes "### Minor Changes" / "### Patch Changes" headings. A new clean-changelog.cjs script removes them so 2nd-gen CHANGELOGs have flat bullets under the version heading. Wired into publish.js to run automatically after `yarn changeset version`. Co-authored-by: Cursor <cursoragent@cursor.com>
| ]; | ||
|
|
||
| function is2ndGen(changeset) { | ||
| return changeset.releases.some((r) => SECOND_GEN_PACKAGES.includes(r.name)); |
There was a problem hiding this comment.
Is it possible to have a changeset that includes a 1st gen package with a name contained in SECOND_GEN_PACKAGES, resulting in unexpected true cases? ✨
I think the danger here is if a changeset includes a 1st and 2nd gen package then the func will return true and the 1st gen entry gets the passthrough format instead of the @changesets/changelog-github format. ✨🤔
| * Hybrid changesets changelog function. | ||
| * | ||
| * - 2nd-gen packages (`@adobe/spectrum-wc`, `@spectrum-web-components/core`): | ||
| * Returns changeset bodies verbatim as CHANGELOG bullets. No commit |
There was a problem hiding this comment.
I'm being pedantic here but it's not verbatim, as we're prepending - 😇✨
| * Returns changeset bodies verbatim as CHANGELOG bullets. No commit | |
| * Returns changeset bodies as CHANGELOG bullets. No commit |
| return ''; | ||
| } | ||
|
|
||
| return '\n\n' + lines.map((line) => `- ${line}`).join('\n'); |
There was a problem hiding this comment.
Does this break markdown headings by prepending - to them? ✨
- Use `every` instead of `some` in `is2ndGen` so mixed changesets (1st + 2nd gen) fall back to the GitHub changelog format safely - Fix JSDoc: "verbatim" -> "as CHANGELOG bullets" (we prepend `- `) - Skip `- ` prefix for lines starting with `#` to avoid breaking markdown headings in changeset bodies Co-authored-by: Cursor <cursoragent@cursor.com>
Description
Reworks
2nd-gen/packages/swc/CHANGELOG.mdahead of the2.0.0-beta1release.0.0.2/0.0.3/0.0.4pre-release history with a single2.0.0-beta1section.@adobe/spectrum-wc, modelled on the Button entry's level of detail (renames, removals, additions, a11y improvements, fixed SWC issue numbers, link to the consumer migration guide).Motivation and context
@adobe/spectrum-wcis going from0.0.4to2.0.0-beta1. The CHANGELOG should reflect the actual scope of the initial public release rather than the internal pre-release patch history that accumulated during dev. Documenting every component up front gives consumers a single place to see what's shipping and how each component differs from its 1st-gen counterpart.Related issue(s)
Screenshots (if appropriate)
N/A — Markdown file.
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
CHANGELOG renders correctly
2nd-gen/packages/swc/CHANGELOG.mdon this branch in a Markdown previewer (or on GitHub).2.0.0-beta1heading is the only version section.Consumer migration guide links resolve
/?path=/docs/components-<name>-consumer-migration-guide--readme) and may need adjustment to match the actual story IDs Storybook generates.Content accuracy spot-check
consumer-migration-guide.mdx(ormigration.md).Device review
Accessibility testing checklist
Keyboard (required — document steps below)
Screen reader (required — document steps below)
@adobe/spectrum-wc), H2 (2.0.0-beta1), H3 (Minor Changes,Patch Changes); bullet items announce in order with no skipped heading levels.