chore(accordion): run component analysis skill#6269
Conversation
|
8b1b3dd to
0336078
Compare
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
0336078 to
775963e
Compare
| - `.spectrum-Accordion-item` | ||
| - `.spectrum-Accordion-itemContent` | ||
| - `.spectrum-Accordion-itemDirectActions` | ||
| - `.spectrum-Accordion-itemHeader` |
There was a problem hiding this comment.
itemHeader, itemHeading, and itemTitle all seem so similar, and easy to misunderstand. We'll have to make sure we have good docs explaining the differences.
| | `.spectrum-Accordion--quiet` | — | Missing from WC | | ||
| | `.spectrum-Accordion--quiet .spectrum-Accordion-itemHeader:active` | — | Missing from WC | | ||
| | `.spectrum-Accordion--quiet .spectrum-Accordion-itemHeader:hover` | — | Missing from WC | | ||
| | `.spectrum-Accordion.spectrum-Accordion--noInlinePadding` | — | Missing from WC | |
There was a problem hiding this comment.
I liked your comment on Nikki's PR. I agree this could be omitted as a attribute
269dfce to
64ed34a
Compare
e64ac01 to
66d4919
Compare
64ed34a to
45c783a
Compare
Description
Runs component analysis skill in order to re-generate rendering & styling migration analysis.
View with Markdown formatting in GitHub
Motivation and context
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Descriptive Test Statement
Descriptive Test Statement
Device review
Accessibility testing checklist
Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).
Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.
Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.