Skip to content

chore(accordion): run component analysis skill#6269

Open
rise-erpelding wants to merge 4 commits into
swc-1854/accordion-migrationfrom
rise-erpelding/accordion-rendering-styling-analysis
Open

chore(accordion): run component analysis skill#6269
rise-erpelding wants to merge 4 commits into
swc-1854/accordion-migrationfrom
rise-erpelding/accordion-rendering-styling-analysis

Conversation

@rise-erpelding
Copy link
Copy Markdown
Collaborator

@rise-erpelding rise-erpelding commented May 11, 2026

Description

Runs component analysis skill in order to re-generate rendering & styling migration analysis.

View with Markdown formatting in GitHub

Motivation and context

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result
  • Descriptive Test Statement

    1. Go here
    2. Do this action
    3. Expect this result

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

Accessibility testing checklist

Required: Complete each applicable item and document your testing steps (replace the placeholders with your component-specific instructions).

  • Keyboard (required — document steps below) — What to test for: Focus order is logical; Tab reaches the component and all interactive descendants; Enter/Space activate where appropriate; arrow keys work for tabs, menus, sliders, etc.; no focus traps; Escape dismisses when applicable; focus indicator is visible.

    1. Go here
    2. Do this action
    3. Expect this result
  • Screen reader (required — document steps below) — What to test for: Role and name are announced correctly; state changes (e.g. expanded, selected) are announced; labels and relationships are clear; no unnecessary or duplicate announcements.

    1. Go here
    2. Do this action
    3. Expect this result

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 11, 2026

⚠️ No Changeset found

Latest commit: 7c54ad2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rise-erpelding rise-erpelding force-pushed the rise-erpelding/accordion-rendering-styling-analysis branch from 8b1b3dd to 0336078 Compare May 11, 2026 16:48
@rise-erpelding rise-erpelding marked this pull request as ready for review May 11, 2026 16:50
@rise-erpelding rise-erpelding requested a review from a team as a code owner May 11, 2026 16:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6269

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@rise-erpelding rise-erpelding force-pushed the rise-erpelding/accordion-rendering-styling-analysis branch from 0336078 to 775963e Compare May 11, 2026 16:56
- `.spectrum-Accordion-item`
- `.spectrum-Accordion-itemContent`
- `.spectrum-Accordion-itemDirectActions`
- `.spectrum-Accordion-itemHeader`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

itemHeader, itemHeading, and itemTitle all seem so similar, and easy to misunderstand. We'll have to make sure we have good docs explaining the differences.

| `.spectrum-Accordion--quiet` | — | Missing from WC |
| `.spectrum-Accordion--quiet .spectrum-Accordion-itemHeader:active` | — | Missing from WC |
| `.spectrum-Accordion--quiet .spectrum-Accordion-itemHeader:hover` | — | Missing from WC |
| `.spectrum-Accordion.spectrum-Accordion--noInlinePadding` | — | Missing from WC |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked your comment on Nikki's PR. I agree this could be omitted as a attribute

@rise-erpelding rise-erpelding force-pushed the rise-erpelding/accordion-rendering-styling-analysis branch 2 times, most recently from 269dfce to 64ed34a Compare May 12, 2026 01:51
@rise-erpelding rise-erpelding force-pushed the swc-1854/accordion-migration branch from e64ac01 to 66d4919 Compare May 12, 2026 01:52
@rise-erpelding rise-erpelding force-pushed the rise-erpelding/accordion-rendering-styling-analysis branch from 64ed34a to 45c783a Compare May 12, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants