Skip to content

feat(zc1301): rename Bash PIPESTATUS var to Zsh pipestatus#1212

Merged
afadesigns merged 1 commit into
mainfrom
feat/zc1301-fix
Apr 24, 2026
Merged

feat(zc1301): rename Bash PIPESTATUS var to Zsh pipestatus#1212
afadesigns merged 1 commit into
mainfrom
feat/zc1301-fix

Conversation

@afadesigns
Copy link
Copy Markdown
Owner

Bash uses $PIPESTATUS for the pipeline exit-code array; Zsh uses the lowercase $pipestatus. Fix renames the identifier at its source position, covering both the dollar-prefixed form and the bare uppercase form. Array subscripts inside a braced reference aren't reached because the parser wraps those in ArrayAccess — a follow-up can extend detection there.

Test plan: tests green, lint clean, one integration test.

Copy link
Copy Markdown
Collaborator

@redteamx redteamx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@github-actions github-actions Bot added test Adding or correcting tests area/source Generic source-tree change (fallback when no specific area fits) labels Apr 24, 2026
@afadesigns afadesigns merged commit a63d91d into main Apr 24, 2026
16 of 17 checks passed
@afadesigns afadesigns deleted the feat/zc1301-fix branch April 24, 2026 19:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/katas/zc1301.go 52.38% 9 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/source Generic source-tree change (fallback when no specific area fits) test Adding or correcting tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants