fix: honor klog -stderrthreshold even when -logtostderr is true#141
Open
pierluigilenoci wants to merge 1 commit intoahmetb:masterfrom
Open
fix: honor klog -stderrthreshold even when -logtostderr is true#141pierluigilenoci wants to merge 1 commit intoahmetb:masterfrom
pierluigilenoci wants to merge 1 commit intoahmetb:masterfrom
Conversation
klog v2 defaults -logtostderr to true, which silently causes -stderrthreshold to be ignored. klog v2.140.0 introduced the legacy_stderr_threshold_behavior flag (kubernetes/klog#432) to decouple the two settings. Set legacy_stderr_threshold_behavior=false so that users can control log verbosity on stderr via -stderrthreshold as expected. Bump k8s.io/klog/v2 from v2.130.1 to v2.140.0 to pick up the fix. Ref: kubernetes/klog#212, kubernetes/klog#432 Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
klog v2 defaults
-logtostderrtotrue, which silently causes-stderrthresholdto be ignored. This means users cannot filter whichseverity levels are printed to stderr.
klog v2.140.0 introduced the
legacy_stderr_threshold_behaviorflag(kubernetes/klog#432) to
decouple the two settings, as discussed in
kubernetes/klog#212.
Changes
k8s.io/klog/v2from v2.130.1 to v2.140.0.legacy_stderr_threshold_behavior=falseright afterklog.InitFlagsso that
-stderrthresholdis honored even when-logtostderr=true.Testing
go build ./...passes.-stderrthreshold; thedefault threshold (
ERROR) is the same as before.