Skip to content

UCM2: Qualcomm: sc8280xp: add Huawei MateBook E Go support#715

Open
whitelewi1-ctrl wants to merge 1 commit intoalsa-project:masterfrom
whitelewi1-ctrl:add-huawei-matebook-e-go-sc8280xp
Open

UCM2: Qualcomm: sc8280xp: add Huawei MateBook E Go support#715
whitelewi1-ctrl wants to merge 1 commit intoalsa-project:masterfrom
whitelewi1-ctrl:add-huawei-matebook-e-go-sc8280xp

Conversation

@whitelewi1-ctrl
Copy link
Copy Markdown

Summary

Add UCM configuration for the Huawei MateBook E Go (GK-W7X), an sc8280xp-based tablet with the same audio codec hardware as the Lenovo ThinkPad X13s (WCD938x + WSA8835 via SoundWire).

  • Add HUAWEI-MateBook-E-Go.conf device configuration
  • Update sc8280xp.conf to match HUAWEI DMI alongside existing LENOVO match
  • Error message only emitted when no known vendor matches

Hardware details

Field Value
Device Huawei MateBook E Go (GK-W7X)
SoC Snapdragon 8cx Gen 3 (sc8280xp)
Audio codec WCD938x (headphones) + WSA8835 v2 (speakers)
Audio bus SoundWire
board_vendor HUAWEI
product_family MateBook E

Test plan

  • Tested on Huawei MateBook E Go with kernel 6.18.8 + Arch Linux
  • Speaker playback, headphone playback, internal mic, headset mic all functional
  • wpctl status shows correct device names (Speaker, Headphones, Internal microphones, Headset)

Add UCM configuration for the Huawei MateBook E Go (GK-W7X), which uses
the same Snapdragon 8cx Gen 3 (sc8280xp) platform as the Lenovo ThinkPad
X13s with identical audio codec hardware (WCD938x + WSA8835 via SoundWire).

The existing sc8280xp.conf only matched the Lenovo X13s DMI string,
causing "model not supported" on any other sc8280xp device. Add a
HUAWEI MateBook E match block and a separate device config file. The
error message is now only emitted when neither vendor matches.

DMI values on the MateBook E Go:
  board_vendor: HUAWEI
  product_family: MateBook E

Tested on Huawei MateBook E Go (GK-W7X) with kernel 6.18.8.

Signed-off-by: whitelewis <whitelewis@users.noreply.github.com>
@perexg
Copy link
Copy Markdown
Member

perexg commented Mar 27, 2026

Not valid signed-off-by line.

@perexg perexg force-pushed the master branch 9 times, most recently from 5c92089 to 90b4ed1 Compare March 30, 2026 15:55
@github-actions github-actions Bot added the signed off by Missing Signed-off-by: line. label Mar 30, 2026
@github-actions
Copy link
Copy Markdown

⚠️ Signed-off-by Validation Issues

The following commits have issues with their Signed-off-by lines:

Please add a proper Signed-off-by: Your Name <your.email@example.com> line to each commit message.

Missing correct Signed-off-by line

This pull request has commits that are missing proper Signed-off-by lines or use invalid email addresses.

Requirements:

  • Each commit must include at least one Signed-off-by: Your Name <your.email@example.com> line
  • Commit author email must appear in at least one Signed-off-by line
  • Commit committer email must appear in at least one Signed-off-by line (if not a GitHub bot)
  • Multiple Signed-off-by lines are allowed for co-authored commits
  • Anonymous GitHub emails (like @users.noreply.github.com) are not allowed
  • The Signed-off-by line indicates that you agree to the Developer Certificate of Origin (DCO)

How to fix:

# Configure your git identity first (if needed):
git config user.name "Your Name"
git config user.email "your.email@example.com"

# For the last commit:
git commit --amend --signoff

# For multiple commits, use interactive rebase:
git rebase -i HEAD~N --signoff

# For co-authored commits, add multiple Signed-off-by lines manually:
git commit --amend
# Then add in the commit message:
# Signed-off-by: Author One <author1@example.com>
# Signed-off-by: Author Two <author2@example.com>

# Then force push:
git push --force-with-lease

Reference: Developer Certificate of Origin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

signed off by Missing Signed-off-by: line.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants