[Multiple-Profile]feat:profile name validation#20698
Open
criticalAY wants to merge 2 commits intoankidroid:mainfrom
Open
[Multiple-Profile]feat:profile name validation#20698criticalAY wants to merge 2 commits intoankidroid:mainfrom
criticalAY wants to merge 2 commits intoankidroid:mainfrom
Conversation
- test: unit test for renaming method
criticalAY
force-pushed
the
mp/profile-name-validation
branch
from
401a9ac to
a909e35
Compare
criticalAY
changed the title
criticalAY
added
the
Blocked by dependency
5 tasks
| profileRegistry.saveProfile(newProfileId, metadata) | ||
|
|
||
| Timber.i("Created new profile: $displayName (${newProfileId.value})") | ||
| Timber.i("Created new profile: ${displayName.value} (${newProfileId.value})") |
Member
There was a problem hiding this comment.
Prefer .toString on the class
david-allison
approved these changes
Apr 9, 2026
Member
david-allison
left a comment
david-allison
left a comment
There was a problem hiding this comment.
Looks great!
ValidationResult is a good abstraction only if you plan to expose these results, I think it's the right call here
david-allison
added
Needs Second Approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Profile Name validation
Fixes
Approach
NA
How Has This Been Tested?
Unit test
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.