fix: keep sync snackbar anchored correctly#20767
Merged
lukstbit merged 1 commit intoankidroid:mainfrom Apr 19, 2026
Merged
Conversation
david-allison
approved these changes
Apr 18, 2026
- onOptionsItemSelected(R.id.action_sync) : collapse toolbarSearchItem before starting the sync. That fires onMenuItemActionCollapse -> showFloatingActionButton(), so the FAB is back by the time the sync result snackbar appears. - onMenuItemActionExpand: after hideFloatingActionButton(), null out activeSnackBar?.anchorView so a live snackbar drops to sit above the keyboard instead of hovering where the FAB used to be. - onMenuItemActionCollapse: after showFloatingActionButton(), re-anchor activeSnackBar?.anchorView to fabMain so it sits above the FAB instead of being overlapped by it.
376f9f3 to
c20df5f
Compare
lukstbit
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
When the sync toolbar button is tapped while the search action view isexpanded, the keyboard is dismissed (focus leaves the search field) but the action view stays expanded, so the FAB remains hidden. The post-sync snackbar therefore shows unanchored, and the FAB is only restored when the user leaves and returns to the activity.
Also, when search is toggled while a snackbar is already showing, the snackbar's anchor becomes stale, either hovering above a hidden FAB (leaving a gap above the keyboard) or overlapping the FAB when it comes back.
Fixes
Approach
onOptionsItemSelected(R.id.action_sync): collapsetoolbarSearchItembefore starting the sync. That firesonMenuItemActionCollapse->showFloatingActionButton(), so the FAB is back by the time the sync result snackbar appears.onMenuItemActionExpand: afterhideFloatingActionButton(), null outactiveSnackBar?.anchorViewso a live snackbar drops to sit above the keyboard instead of hovering where the FAB used to be.onMenuItemActionCollapse: aftershowFloatingActionButton(), re-anchoractiveSnackBar?.anchorViewtofabMainso it sits above the FAB instead of being overlapped by it.How Has This Been Tested?
Pixel 10
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.