fix(app): handle missing session route#24673
Open
kill74 wants to merge 2 commits intoanomalyco:devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23514
Type of change
What does this PR do?
Handles the case where the app is opened on a stale
/session/:idroute and the connected server does not have that session.Previously,
sync.session.sync(id)could throw aNotFoundError, which reached the app error boundary and showed a crash screen. This change detects that specific missing-session error, shows a toast, and navigates back instead of crashing.It also avoids surfacing the same missing-session error from the scheduled refresh path.
How did you verify your code works?
bun lintbun turbo typecheck --filter=@opencode-ai/appScreenshots / recordings
N/A
Checklist