Fix several HasNext() that should rely on response.HasMore#182
Fix several HasNext() that should rely on response.HasMore#182xoofx wants to merge 14 commits intoanthropics:nextfrom
Conversation
- Filter sessions by attached memory store: GET /v1/sessions accepts a new optional `memory_store_id` query param - BetaListUserProfilesResponse always returns `next_page` (now non-nullable in SDK types) - Allow `max_tokens: 0` on message creation (previously rejected as below minimum) - Rename "BYOC" to "self-hosted" in environment config docs - Improve SDK reference docs: human-readable method summaries (e.g. "Delete a memory store"), richer parameter and field descriptions, and fuller enum docs across the managed-agents-memory beta - CLI: accept `id` as an alias for memory-store, memory, agent, session, vault, environment, and credential identifiers on update commands for easier piping from stdin
xoofx
force-pushed
the
fix-HasNext-to-use-HasMore
branch
from
427f880 to
d0930c3
Compare
* feat(memory): add beta memory tool * chrore: update memory tool example
…ck (anthropics#183) When HostedFileContent has an image MediaType (e.g. image/png), map it to BetaImageBlockParam with BetaFileImageSource instead of always using BetaRequestDocumentBlock with BetaFileDocumentSource. This mirrors the OpenAI Responses adapter pattern (dotnet/extensions L1110-1117) and allows users to send hosted file images via MEAI abstractions without dropping down to RawRepresentation. Applied in both user message content conversion and tool result content conversion paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Is this reproducible on Anthropic's API? |
I don't think so because the .NET SDK was built with the behavior of Anthropic endpoint. I just tested it with an Anthropic endpoint and As |
xoofx
force-pushed
the
fix-HasNext-to-use-HasMore
branch
from
d0930c3 to
5f0597d
Compare
|
I have rebased on latest |
|
Hello, would it be possible to merge this PR? It is blocking the usage of Anthropic API with other model providers. I have to maintain a fork of this project and add it to my projects locally in order to get this fix. |
|
@xoofx Hey sorry, just bringing this up with the team internally given that this only affects a 3rd party API. |
Ok, thanks. In case this is not accepted, I would like to understand why the existing code is not using |
5 participants
When trying the API on Kimi 2.6 provider, I discovered that the
ModelListPage.cswith HasNext() was looping forever (and eventually failed).Their LastId is not null and always equal to the FirstId. While the
HasMoreof the response is correctly set.This PR is addressing this by replacing all HasNext() for which we can use a
response.HasMoreinstead.