Prevent ArrayData::slice length overflow

[alamb]

Which issue does this PR close?

• None.

Rationale for this change

ArrayData::slice checked bounds using unchecked usize addition. In optimized builds, very large length values could wrap offset + length, allowing invalid slice arguments to create ArrayData with inconsistent length and offset metadata instead of panicking.

What changes are included in this PR?

This updates ArrayData::slice to use checked arithmetic when computing the slice end.

The panic documentation is updated to describe the overflow case.

Are these changes tested?

Yes. This adds a regression test covering a slice-of-slice call where offset + length overflows. The new regression was also verified in release mode.

Validated with:

cargo test -p arrow-data test_slice_panics_on_offset_length_overflow --release

Are there any user-facing changes?

Invalid ArrayData::slice arguments where offset + length overflows now panic consistently across build modes. There are no API changes.

[alamb]

Here is how the test fails without the code change

It seems like maybe we should start running some targeted tests in release builds too to really ensure these cases are covered 🤔

andrewlamb@Andrews-MacBook-Pro-3:~/Software/arrow-rs$ cargo test -p arrow-data test_slice_panics_on_offset_length_overflow
   Compiling arrow-data v58.1.0 (/Users/andrewlamb/Software/arrow-rs/arrow-data)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.45s
     Running unittests src/lib.rs (target/debug/deps/arrow_data-c6408ac97be22d82)

running 1 test
test data::tests::test_slice_panics_on_offset_length_overflow - should panic ... FAILED

failures:

---- data::tests::test_slice_panics_on_offset_length_overflow stdout ----

thread 'data::tests::test_slice_panics_on_offset_length_overflow' (46323764) panicked at arrow-data/src/data.rs:581:17:
attempt to add with overflow
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
note: panic did not contain expected string
      panic message: "attempt to add with overflow"
 expected substring: "offset + length overflow"

failures:
    data::tests::test_slice_panics_on_offset_length_overflow

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 27 filtered out; finished in 0.00s

error: test failed, to rerun pass `-p arrow-data --lib`

[alamb]

Follow on PR:

• Run arrow tests for --lib and --tests on CI builds #9814