fix: ResourceClassInfoTrait::isResourceClass() is always true

[Maxcastel]

Q	A
Branch?	4.3
Tickets	Closes #..., closes #...
License	MIT

Problem

final class ParameterResourceMetadataCollectionFactory implements ResourceMetadataCollectionFactoryInterface
{
    use ResourceClassInfoTrait;

    public function __construct(
        private readonly PropertyNameCollectionFactoryInterface $propertyNameCollectionFactory,
        private readonly PropertyMetadataFactoryInterface $propertyMetadataFactory,
        private readonly ?ResourceMetadataCollectionFactoryInterface $decorated = null,
        private readonly ?ContainerInterface $filterLocator = null,
        private readonly ?NameConverterInterface $nameConverter = null,
        private readonly ?LoggerInterface $logger = null,
        ?ResourceClassResolverInterface $resourceClassResolver = null,
    ) {
        $this->resourceClassResolver = $resourceClassResolver;
    }

}

$this->resourceClassResolver and $this->resourceMetadataFactory are always null, so the fallback always returns true, even if the class is not an API resource (does not have #[ApiResource]):

private function isResourceClass(string $class): bool
{
    // dump($this->resourceClassResolver); //null
    // dd($this->resourceMetadataFactory); //null
    if ($this->resourceClassResolver instanceof ResourceClassResolverInterface) {
        return $this->resourceClassResolver->isResourceClass($class);
    }

    if ($this->resourceMetadataFactory) {
        return \count($this->resourceMetadataFactory->create($class)) > 0;
    }

    return true;
}

Solution

• ResourceClassInfoTrait::isResourceClass(): changed the fallback to false so that the conditions remain the source of truth
• Added tests for ResourceClassInfoTrait (there were tests for ClassInfoTrait, but none for ResourceClassInfoTrait)

[soyuka]

thanks!