DOC-852 | Removed collection methods from JavaScript API#927
DOC-852 | Removed collection methods from JavaScript API#927
Conversation
|
Deploy Preview Available Via |
📝 WalkthroughWalkthroughDocumentation-only updates: removed five lines from a collection reference comment and added a new "Removed collection methods" subsection in the 4.0 release notes listing multiple removed JavaScript collection methods with migration guidance. No code or public API declarations changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
site/content/arangodb/4.0/release-notes/version-4.0/api-changes-in-4-0.md (1)
56-58: Clarify this is client-side JavaScript API scope in 4.0.To avoid confusion with 4.0’s removal of server-side JavaScript, consider explicitly stating these removed
_collection_methods are from client-side JavaScript usage (for example, arangosh context).Based on learnings: In ArangoDB 4.0, server-side JavaScript execution has been removed entirely, so 4.0 docs should avoid ambiguity around JavaScript scope.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@site/content/arangodb/4.0/release-notes/version-4.0/api-changes-in-4-0.md` around lines 56 - 58, Update the sentence about removed _collection_ methods to explicitly state these removals apply to the client-side JavaScript API (e.g., arangosh/context) in ArangoDB 4.0; mention that server-side JavaScript execution has been removed entirely in 4.0 so this list refers only to client-side usage and won't affect server-side code, and ensure references like "_collection_ objects" and the linked JavaScript API docs reflect that client-side scope.site/content/arangodb/4.0/release-notes/version-4.0/incompatible-changes-in-4-0.md (1)
30-33: Consider clarifying JavaScript scope for 4.0 in this incompatible-change summary.A short qualifier (client-side JavaScript API) here would make this section consistent with 4.0’s server-side JavaScript removal and reduce reader confusion.
Based on learnings: In ArangoDB 4.0, server-side JavaScript execution has been removed entirely, so JavaScript references in 4.0 docs should be explicitly scoped when needed.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@site/content/arangodb/4.0/release-notes/version-4.0/incompatible-changes-in-4-0.md` around lines 30 - 33, Update the sentence "The following methods have been removed from _collection_ objects" to explicitly scope it as client-side JavaScript by adding a short qualifier such as "client-side JavaScript API" (e.g., "The following methods have been removed from client-side JavaScript API _collection_ objects") so readers don't confuse this with server-side JS removals; ensure the qualifier appears near the phrase "_collection_ objects" for clarity and consistency with other 4.0 notes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@site/content/arangodb/4.0/release-notes/version-4.0/api-changes-in-4-0.md`:
- Around line 179-180: The fragment link to "#geojson-interpretation" is
unresolved; either add a corresponding heading/anchor titled "GeoJSON
interpretation" somewhere appropriate in this document (so the [GeoJSON
interpretation](`#geojson-interpretation`) link resolves), or change the link
target/text to point to an existing section (or remove the parenthetical
entirely). Update the sentence containing "Use an AQL query like this... (see
[GeoJSON interpretation](`#geojson-interpretation`))" accordingly and ensure the
new heading or link text uses the exact anchor name "geojson-interpretation" so
the fragment resolves.
- Around line 183-192: The AQL in the db._query call uses a value bind
`@collection` for the FOR ... IN clause which will fail; change the collection
bind inside the query string to a collection bind @@collection (double @) and
keep the bind parameter key in the parameter object as "collection" so the
db._query invocation (the db._query(`...`, { "@collection": "coll", ... }) call)
passes the collection via the @@collection placeholder; update the query string
in the db._query invocation shown (the GEO_POLYGON / FOR doc IN ... block) to
use @@collection instead of `@collection`.
---
Nitpick comments:
In `@site/content/arangodb/4.0/release-notes/version-4.0/api-changes-in-4-0.md`:
- Around line 56-58: Update the sentence about removed _collection_ methods to
explicitly state these removals apply to the client-side JavaScript API (e.g.,
arangosh/context) in ArangoDB 4.0; mention that server-side JavaScript execution
has been removed entirely in 4.0 so this list refers only to client-side usage
and won't affect server-side code, and ensure references like "_collection_
objects" and the linked JavaScript API docs reflect that client-side scope.
In
`@site/content/arangodb/4.0/release-notes/version-4.0/incompatible-changes-in-4-0.md`:
- Around line 30-33: Update the sentence "The following methods have been
removed from _collection_ objects" to explicitly scope it as client-side
JavaScript by adding a short qualifier such as "client-side JavaScript API"
(e.g., "The following methods have been removed from client-side JavaScript API
_collection_ objects") so readers don't confuse this with server-side JS
removals; ensure the qualifier appears near the phrase "_collection_ objects"
for clarity and consistency with other 4.0 notes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5a50e3da-f9e2-445d-8f98-5572baab0ad5
📒 Files selected for processing (3)
site/content/arangodb/4.0/develop/javascript-api/@arangodb/collection-object.mdsite/content/arangodb/4.0/release-notes/version-4.0/api-changes-in-4-0.mdsite/content/arangodb/4.0/release-notes/version-4.0/incompatible-changes-in-4-0.md
💤 Files with no reviewable changes (1)
- site/content/arangodb/4.0/develop/javascript-api/@arangodb/collection-object.md
Description
collection.range()arangodb#22511Upstream PRs
Summary by CodeRabbit