Preserve failAfter directive in isoltest ASTJSON reformatting#16574
Merged
clonker merged 1 commit intoMay 7, 2026
Conversation
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
When isoltest updates test expectations for ASTJSON tests, it calls printSource() to rewrite the .sol input file. The function was not outputting the failAfter directive that was parsed and stored in m_expectedFailAfter, causing the directive to be silently dropped. Fixes argotorg#14093
clonker
force-pushed
the
fix-isoltest-failafter-stripping
branch
from
1f06566 to
ea0a8c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14093.
When
isoltestupdates test expectations for ASTJSON tests (via--accept-updates), it callsASTJSONTest::printSource()to rewrite the.solinput file. The function was not outputting thefailAfterdirective that was parsed and stored inm_expectedFailAfter, causing the directive to be silently dropped during reformatting.The Fix
Added output of the
failAfterdirective inASTJSONTest::printSource()whenm_expectedFailAfterhas a value. The directive is written in the same format thatfillSources()parses:// failAfter: <CompilerState>.Changes
test/libsolidity/ASTJSONTest.cpp: AddfailAfteroutput toprintSource()(3 lines)Testing