Open
Conversation
This piece of logic was swapping top to the tail region if case the top is not in its right place and it wants to be in tail anyway. I don't have an explanation why this is useful, but it seems to improve code generation on most external benchmarks.
blishko
commented
Apr 15, 2026
Comment on lines
-188
to
+189
| // gas ssaCFGOptimized: 809663 | ||
| // gas ssaCFGOptimized code: 570000 | ||
| // gas ssaCFGOptimized: 809711 | ||
| // gas ssaCFGOptimized code: 570600 |
Contributor
Author
There was a problem hiding this comment.
This is a small regression, but it is the only one on external contracts.
Member
There was a problem hiding this comment.
regression by 0.0059% for runtime and by 0.105% for deploy.. i think it's fine..
| // gas legacy: 4234020 | ||
| // gas legacyOptimized: 2318668 | ||
| // gas ssaCFGOptimized: 1882355 | ||
| // gas ssaCFGOptimized: 1841235 |
Contributor
Author
There was a problem hiding this comment.
This is actually a 2% improvement.
Comment on lines
-11
to
+12
| // SWAP3| * | lit2 v2 v0 | ||
| // POP| v0 | lit2 v2 | ||
| // DUP3| v0 | lit2 v2 v0 |
Contributor
Author
There was a problem hiding this comment.
This is a bit unfortunate, I would like to fix this somehow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This piece of logic was swapping top to the tail region if case the top is not in its right place and it wants to be in tail anyway.
I don't have an explanation why this is useful, but it seems to improve code generation on most external benchmarks.