Fix incorrect assumption about erc7201 constant function call#16672
Open
matheusaaguiar wants to merge 3 commits into
Open
Fix incorrect assumption about erc7201 constant function call#16672matheusaaguiar wants to merge 3 commits into
matheusaaguiar wants to merge 3 commits into
Conversation
matheusaaguiar
changed the title
nikola-matic
reviewed
May 5, 2026
Contributor
nikola-matic
left a comment
nikola-matic
left a comment
There was a problem hiding this comment.
I'd say this warrants a changelog - it's a user visible change after all.
| case FunctionType::Kind::ERC7201: | ||
| { | ||
| solAssert(_functionCall.arguments().size() == 1); | ||
| if (_functionCall.arguments().size() != 1) |
Contributor
Author
There was a problem hiding this comment.
The problem here is that for certain cases, like array lengths, the constant folding happens before, during DeclarationTypeChecker visits... I could add that there, but feels a bit out of place too.
At first, I wanted to rely on TypeChecker and missed that this could be triggered before it was verified (see this comment)
matheusaaguiar
force-pushed
the
fix_erc7201_invalid_param_number_ice
branch
from
e902b88 to
3bc1409
Compare
matheusaaguiar
force-pushed
the
fix_erc7201_invalid_param_number_ice
branch
from
3bc1409 to
7284376
Compare
matheusaaguiar
force-pushed
the
fix_erc7201_invalid_param_number_ice
branch
from
7284376 to
c877f69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16633.