A set of commits aimed at reducing the occurences of CI test failures.#777
Open
borine wants to merge 6 commits intoarkq:masterfrom
Open
A set of commits aimed at reducing the occurences of CI test failures.#777borine wants to merge 6 commits intoarkq:masterfrom
borine wants to merge 6 commits intoarkq:masterfrom
Conversation
snd_seq_event_input() blocks until the event timestamp is reached, according to the system clock. The ble_midi_decode() function limits the time drift from system clock to 500ms. So in the worst case, with 9 events to process, a total of 4500ms will pass just blocked in calls to snd_seq_event_input(). Added to the total of 2100ms in usleep() calls, this gives a worst-case test time of 6600ms. The default default test timeout in libcheck is 4000ms, and so we get occasional test timeout failures. This commit increases the test-ble-midi timeout to 7000ms to avoid these failures.
If a client re-opens a pcm immediately after closing the file descriptor then there is a race between setting the "stopping" flag and starting the new acquisition procedure. It is not possible to make closing the fd and setting the flag into an atomic operation, so this race in unavoidable and there is always a non-zero risk that acquistion will collide with an in-progress release procedure. This has been one of the causes of occasional CI test failures in test-alsa-pcm:test-test_playback_hw_set_free. The risk is significantly reduced by applying a short delay into the acquisition procedure if the transport is not already idle.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #777 +/- ##
==========================================
- Coverage 70.52% 70.22% -0.30%
==========================================
Files 101 101
Lines 16788 16797 +9
Branches 2643 2645 +2
==========================================
- Hits 11839 11796 -43
- Misses 4833 4885 +52
Partials 116 116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Insert a brief sleep before switching codecs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still some occasional failures remaining, but overall the failure rate is greatly improved.
Tests with known races that can still cause failure:
Tests that may still occasionally fail for unknown reasons: