Field name included in custom error messages#487
Open
jorgefuertes wants to merge 2 commits intoasaskevich:masterfrom
Open
Field name included in custom error messages#487jorgefuertes wants to merge 2 commits intoasaskevich:masterfrom
jorgefuertes wants to merge 2 commits intoasaskevich:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The error strings are different from the provided error messages to the custom error messages. First ones included the field name. When using this feature from a front application, for example, with the custom error message you don't know which field is referred.
Go validator error message:
password: does not validate as stringlength(3|50)Custom error messages:
Should have between 3 to 50 chars.While it should be:
password: Should have between 3 to 50 chars.I've modified the test to be OK with the new custom messages.
This change is