fix(metrics): clear state in publishStoredMetrics even when throwOnEmptyMetrics throws#5213
Open
fix(metrics): clear state in publishStoredMetrics even when throwOnEmptyMetrics throws#5213
Conversation
…ptyMetrics throws When serializeMetrics() threw due to throwOnEmptyMetrics, the cleanup calls (clearMetrics, clearDimensions, clearMetadata) were never reached, causing dimensions and metadata to leak into subsequent publishes. Wrap the serialize/emit block in try/finally to guarantee cleanup. Also add tests for the disabled code path, removing the v8 ignore comment. Closes #5207
powertools-for-aws-oss-automation
Bot
added
size/M
powertools-for-aws-oss-automation
Bot
added
size/M
powertools-for-aws-oss-automation
Bot
added
size/M
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
When
serializeMetrics()throws due tothrowOnEmptyMetrics, the cleanup calls (clearMetrics,clearDimensions,clearMetadata) inpublishStoredMetrics()are never reached. This causes dimensions and metadata to leak into subsequent publish calls.try/finallyto guarantee state cleanup even when an exception is throwndisabled=truecode path inpublishStoredMetrics, removing the/* v8 ignore else */coverage pragmaIssue number: closes #5207
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.