Add keyword capture for charset and add brotli#571
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
- Coverage 82.93% 81.87% -1.07%
==========================================
Files 41 42 +1
Lines 2743 2780 +37
Branches 958 970 +12
==========================================
+ Hits 2275 2276 +1
- Misses 282 318 +36
Partials 186 186
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Babili uses the charset for mangling from
IdentifierandStringLiteral. This PR adds the characters from the keywords (const, let, var, class, typeof, void, delete, etc...) to compute the frequency of the characters in the charset to enable better compression.This computing of frequency somehow increase thes gzip and brotli size.
Results:
without this patch: (BEFORE)
With this patch (AFTER)