Add BuildPattern::AlwaysLazy to enable lazy building for both debug and release.#257
Open
lgarron wants to merge 1 commit intobaoyachi:masterfrom
Open
Add BuildPattern::AlwaysLazy to enable lazy building for both debug and release.#257lgarron wants to merge 1 commit intobaoyachi:masterfrom
BuildPattern::AlwaysLazy to enable lazy building for both debug and release.#257lgarron wants to merge 1 commit intobaoyachi:masterfrom
Conversation
… and release. This allows developers to benefit from `shadow-rs` when incremental release builds are necessary for development: baoyachi#232 `AlwaysLazy` is a bit of a funky name. It would be more intuitive for `Lazy` to be something like `LazyInDebug`, so that `Lazy` is… simply "lazy". But that would be a breaking change to the build API at this point. This introduces a bit of a footgun, because it allows the timestamp for a release build to be arbitrarily far out of date. A better middle ground might be to support rounding to a recent timestamp like midnight UTC (similar to what Chromium implemented: https://chromium.googlesource.com/chromium/src.git/+/08d91b75212b6592f05ff993d5a71c0f5a546563 ). But `AlwaysLazy` is a simple fix that unblocks `shadow-rs` for some use cases with minimal code changes for now.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows developers to benefit from
shadow-rswhen incremental release builds are necessary for development: #232AlwaysLazyis a bit of a funky name. It would be more intuitive forLazyto be something likeLazyInDebug, so thatLazyis… simply "lazy". But that would be a breaking change to the build API at this point.This introduces a bit of a footgun, because it allows the timestamp for a release build to be arbitrarily far out of date. A better middle ground might be to support rounding to a recent timestamp like midnight UTC (similar to what Chromium implemented: https://chromium.googlesource.com/chromium/src.git/+/08d91b75212b6592f05ff993d5a71c0f5a546563 ). But
AlwaysLazyis a simple fix that unblocksshadow-rsfor some use cases with minimal code changes for now.