Truncate "Detecting cycles with roots" log to avoid huge java.log entries#29380
Open
hauserx wants to merge 1 commit intobazelbuild:masterfrom
Open
Truncate "Detecting cycles with roots" log to avoid huge java.log entries#29380hauserx wants to merge 1 commit intobazelbuild:masterfrom
hauserx wants to merge 1 commit intobazelbuild:masterfrom
Conversation
…ries. When a build has tens or hundreds of thousands of top-level keys, the full cycleRoots collection could be serialized into a single log line. Cap the logged sample at 100 entries and include the total count.
github-actions
Bot
added
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a build has tens or hundreds of thousands of top-level keys, the full cycleRoots collection could be serialized into a single log line. Cap the logged sample at 100 entries and include the total count.
Motivation
Our java.log grew to ~200MB in some cases due to this single log for builds with pre-selected targets.
Build API Changes
No
Checklist
Release Notes
RELNOTES: None