Add timeout param to ctx.actions.run#29395
Open
jpopadak wants to merge 1 commit intobazelbuild:masterfrom
Open
Add timeout param to ctx.actions.run#29395jpopadak wants to merge 1 commit intobazelbuild:masterfrom
jpopadak wants to merge 1 commit intobazelbuild:masterfrom
Conversation
- Add timeout parameter to ctx.actions.run() and ctx.actions.run_shell() Starlark API - Add SpawnAction.Builder.setTimeout(Duration) that sets ExecutionRequirements.TIMEOUT in execution info - Add empty-string guard to Spawns.getTimeout() - Add unit tests for setTimeout and Starlark timeout parameter (positive, zero, null, negative, override)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add timeout param to
ctx.actions.runfor RBE and local environment use.ctx.actions.run()andctx.actions.run_shell()Starlark APISpawnAction.Builder.setTimeout(Duration)that setsExecutionRequirements.TIMEOUTin execution infoSpawns.getTimeout()setTimeoutand Starlark timeout parameter (positive, zero, null, negative, override)Motivation
Some actions in a Remote Execution environment can take a long time and there is no way to split them up due to some third party application commands. The environment can have their own timeouts, but if a single action needs to be longer, it should be explicitly configured for that longer timeout.
Build API Changes
Does this PR affect the Build API? Yes - Starlark API
If yes, please answer the following:
Checklist
Release Notes
RELNOTES[NEW]: Add parameter
timeouttoctx.actions.{run,run_shell}