chore(deps): update dependency net.bytebuddy:byte-buddy-agent to v1.18.8-jdk5#8293
Closed
renovate-bot wants to merge 1 commit intobazelbuild:masterfrom
Closed
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the net.bytebuddy:byte-buddy-agent dependency to version 1.18.8-jdk5. The review identifies a version mismatch with the byte-buddy dependency and a missing update to the maven_install.json lockfile, which will cause build failures. It is also recommended to use the standard version instead of the -jdk5 variant unless legacy support is necessary.
| "org.objenesis:objenesis:3.5", | ||
| "net.bytebuddy:byte-buddy:1.18.7", | ||
| "net.bytebuddy:byte-buddy-agent:1.18.7", | ||
| "net.bytebuddy:byte-buddy-agent:1.18.8-jdk5", |
There was a problem hiding this comment.
Updating net.bytebuddy:byte-buddy-agent to 1.18.8-jdk5 introduces two issues:
- Version Mismatch: It no longer matches
net.bytebuddy:byte-buddy(currently1.18.7on line 79). These dependencies should be kept in sync to ensure compatibility. - Missing Lockfile: The
maven_install.jsonlockfile has not been updated in this PR. Sincefail_if_repin_required = Trueis set on line 104, the build will fail until the lockfile is re-pinned.
Additionally, the -jdk5 suffix indicates a legacy compatibility build. Unless this project specifically requires support for Java 5 environments, the standard 1.18.8 version is generally preferred.
10e98f5 to
b15a243
Compare
b15a243 to
e69de62
Compare
e69de62 to
61ca717
Compare
61ca717 to
1ca89b4
Compare
1ca89b4 to
fbde233
Compare
fbde233 to
d6c83f8
Compare
d6c83f8 to
5888da5
Compare
5888da5 to
22ee047
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.18.7→1.18.8-jdk5Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.