Skip to content

feat: add interactive CSV column mapper to DICOM standard#439

Open
JoshuaSiraj wants to merge 6 commits intoJoshuaSiraj/nifti-indexfrom
JoshuaSiraj/dicommap
Open

feat: add interactive CSV column mapper to DICOM standard#439
JoshuaSiraj wants to merge 6 commits intoJoshuaSiraj/nifti-indexfrom
JoshuaSiraj/dicommap

Conversation

@JoshuaSiraj
Copy link
Copy Markdown
Collaborator

@skim2257 @strixy16

Should I change the name of the files from dicommap.py to map.py?

@JoshuaSiraj JoshuaSiraj changed the base branch from main to JoshuaSiraj/nifti-index March 4, 2026 18:23
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 4, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 587d98ac-a228-487a-8414-c3a8ee02150a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch JoshuaSiraj/dicommap

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@katy-scott
Copy link
Copy Markdown
Collaborator

@skim2257 @strixy16

Should I change the name of the files from dicommap.py to map.py?

I like dicommap. I feel like map is too general and could be used for something in the future.

Comment thread src/imgtools/cli/dicommap.py Outdated
)
@click.option(
"-y",
"--yes",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really vague flag, maybe change to interactive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants