feat(zoom): add trackpad pinch-to-zoom support#1633
Open
swaroopbutala wants to merge 1 commit intobox:masterfrom
Open
feat(zoom): add trackpad pinch-to-zoom support#1633swaroopbutala wants to merge 1 commit intobox:masterfrom
swaroopbutala wants to merge 1 commit intobox:masterfrom
Conversation
On Mac trackpads, pinch gestures emit wheel events with ctrlKey set to
true. This change adds a wheelZoomHandler to DocBaseViewer, ImageBaseViewer,
and TextBaseViewer that intercepts these events to provide smooth,
proportional zoom behavior without triggering native browser zoom.
Summary of changes:
- DocBaseViewer: Added wheelZoomHandler that adjusts pdfViewer scale
proportionally, clamped between MIN_SCALE and MAX_SCALE
- ImageBaseViewer: Added wheelZoomHandler that adjusts image element width
proportionally and emits zoom events
- TextBaseViewer: Added wheelZoomHandler that adjusts font size
proportionally, plus new bindDOMListeners/unbindDOMListeners lifecycle
methods and proper cleanup in destroy()
- All viewers register the wheel listener with { passive: false } to allow
preventDefault() and block native browser zoom
- Added comprehensive unit tests for all three viewers
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Mac trackpads, pinch gestures emit wheel events with ctrlKey set to true. This change adds a wheelZoomHandler to DocBaseViewer, ImageBaseViewer, and TextBaseViewer that intercepts these events to provide smooth, proportional zoom behavior without triggering native browser zoom.
Summary of changes: