feat: migrate Trade data to SQLite with TradeLegacy for backward compatibility by Blazebrain · Pull Request #3106 · cake-tech/cake_wallet

Blazebrain · 2026-03-18T19:01:07Z

Issue Number (if Applicable): Fixes #

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

Initial Manual Tests Passed
Double check modified code and verify it with the feature/task requirements
Format code
Look for code duplication
Clear naming for variables and methods
Manual tests in accessibility mode (TalkBack on Android) passed

…atibility

OmarHatem28 · 2026-03-23T22:31:55Z

+    Box<TradeLegacy> box,
+  ) async {
+    printV('Migrating Trades to SQLite: start');
+    final sw = Stopwatch()..start();


debugging and forgotten?

OmarHatem28 · 2026-03-23T22:41:29Z

  int fromRaw = -1;

  CryptoCurrency? get from => CryptoCurrency.safeDeserialize(raw: fromRaw);

-  @HiveField(3, defaultValue: -1)
  int toRaw = -1;

  CryptoCurrency? get to => CryptoCurrency.safeDeserialize(raw: toRaw);


we want to get rid of this, and save the currency itself, not the Raw number.
this was the main issue why we want the migration, is because tokens don't have raw value, so when you try and parse the raw value to currency it will not find it and fail.

so get rid of raw, and safe the currency itself so we don't need to parse anything and just show the saved currency for this trade

OmarHatem28 · 2026-03-23T22:42:35Z

  CryptoCurrency? get userCurrencyFrom {
    if (userCurrencyFromRaw == null || userCurrencyFromRaw!.isEmpty) {
      return null;
    }
    final underscoreIndex = userCurrencyFromRaw!.indexOf('_');
+    if (underscoreIndex < 0) {
+      return CryptoCurrency(
+        title: userCurrencyFromRaw!,
+        tag: null,
+        name: '',
+        raw: -1,
+        decimals: 1,
+      );
+    }


check with @serhii-bor what was the reason for those getters and variables as well, and remove them as well if it fits

OmarHatem28 · 2026-03-23T23:34:03Z

+  CryptoCurrency? get _from => trade.fromRaw >= 0 ? trade.from : trade.userCurrencyFrom;

-  String get tradeFormattedReceiveAmount => displayMode == BalanceDisplayMode.hiddenBalance
-      ? "---"
-      : appStore.amountParsingProxy
-          .getDisplayCryptoAmount(trade.receiveAmountFormatted(), trade.to!);
+  CryptoCurrency? get _to => trade.toRaw >= 0 ? trade.to : trade.userCurrencyTo;


things like this would be removed as well, since we would have the currency directly

OmarHatem28 · 2026-03-24T00:01:41Z

+  fromRaw INTEGER NOT NULL DEFAULT -1,
+  toRaw INTEGER NOT NULL DEFAULT -1,


those 2 and also userCurrencyFromRaw userCurrencyToRaw should be removed in this migration and replaced with the currency it self, we can do it as a TEXT with the value being the stringified version of the json map of the currency, but then you need to find a way to distinguish between tokens and currencies, and different tokens (erc, spl, trx, etc...)

…W-1423-Migrate-Trade-Object-To-SQLite

MrCyjaneK · 2026-04-16T10:44:11Z

+  String? fromCurrencyJson;

-  CryptoCurrency? get from => CryptoCurrency.safeDeserialize(raw: fromRaw);
+  String? toCurrencyJson;


{ "version": 1, "title": "XMR", "name": "xmr", "decimals": 12, "raw": 0, "fullName": "Monero", "iconPath": "assets/images/crypto/monero.webp", "flatIconPath": "assets/new-ui/balance_card_icons/monero.svg" }

Some of the data we store here is very fragile (iconPath / flatIconPath).

MrCyjaneK · 2026-04-16T10:49:24Z

+
+  static bool _hasValidString(String? value) => value != null && value.trim().isNotEmpty;
+
+  void mergeFindTradeByIdResult(Trade updated) {


nit: since sqlite fields accept NULL and things like createdAt / expiredAt are still nullable this function can be heavily simplified to just contain raw x = updated.x or x = updated.x?.trim() instead of the if conditions.

MrCyjaneK · 2026-04-16T10:50:21Z

+      sourceTokenAmountRaw = updated.sourceTokenAmountRaw;
+    }
+
+    internalId = keepInternalId;


We are not touching internalId anywhere so internalId = keepInternalId; and final keepInternalId = internalId; is unnecessary

MrCyjaneK · 2026-04-16T11:07:13Z

+
+import 'package:cw_core/crypto_currency.dart';
+
+class TradeCurrencySnapshot {


I'm really allergic to constant-schema JSON in SQL databases :p

In addition to that a few things:

flatIconPath and chainIconPath are not guaranteed to be constant as we may move assets in future.

Also I've noticed that in case when the currency is not explicitly supported by us the JSON looks like this:

{ "version": 1, "title": "SUN", "name": "SUN", "decimals": 18, "raw": -1, "tag": "TRX", "fullName": "SUN" }

nit: I'd prefer if we store these fields as raw values in the SQL table (currencyFromName, currencyFromDecimals etc...) to make our future life easier, assuming that in future we will want to lookup all TRX trades we can use SQL instead of manually parsing through every trade JSON object, or doing complex migrations.
Same with updating the fields, chainIconPath update, for example during a migration, can be done much easier without querying the entire table and doing json.parse on every row.

MrCyjaneK · 2026-04-16T11:14:35Z

-          CakeImageWidget(imageUrl: _getIconPath(from),
-              width: currencyIconSize, height: currencyIconSize),
+          CakeImageWidget(
+              imageUrl: _getIconPath(from), width: currencyIconSize, height: currencyIconSize),


note: here we may use asset icon that doesn't exist.

MrCyjaneK · 2026-04-16T11:26:28Z


  @override
-  DateTime get date => trade.createdAt!;
+  DateTime get date => trade.createdAt ?? DateTime.now();


nit: I'd probably default to DateTime.fromMillisecondsSinceEpoch(0, isUtc: true);

MrCyjaneK · 2026-04-16T13:18:13Z

-    try { // temporarily until we migrate from hive to sqlite and store the full currency object
+    try {
      if (currency.iconPath != null) {
        return currency.iconPath!;


here we may use iconPath that is stale from the serialization

feat: migrate Trade data to SQLite with TradeLegacy for backward comp…

e24b5ff

…atibility

Blazebrain self-assigned this Mar 18, 2026

Blazebrain requested a review from OmarHatem28 March 18, 2026 19:01

OmarHatem28 requested changes Mar 24, 2026

View reviewed changes

OmarHatem28 added the Needs Changes label Mar 24, 2026

Blazebrain added 2 commits March 31, 2026 10:47

Merge branch 'dev' of https://github.com/cake-tech/cake_wallet into C…

7099ee3

…W-1423-Migrate-Trade-Object-To-SQLite

feat: persist full currency snapshots in sql storage, not raw-only [WIP]

1e65121

Blazebrain added Work in Progress and removed Needs Changes labels Apr 1, 2026

Blazebrain requested a review from OmarHatem28 April 1, 2026 05:32

feat: persist full trade currency snapshots in sql storage

3123fd9

Blazebrain added Ready for Review and removed Work in Progress labels Apr 1, 2026

Blazebrain marked this pull request as ready for review April 1, 2026 09:00

Blazebrain added 2 commits April 1, 2026 10:24

Merge branch 'dev' of https://github.com/cake-tech/cake_wallet into C…

2d43490

…W-1423-Migrate-Trade-Object-To-SQLite

Merge branch 'dev' of https://github.com/cake-tech/cake_wallet into C…

97495a9

…W-1423-Migrate-Trade-Object-To-SQLite

OmarHatem28 requested a review from MrCyjaneK April 15, 2026 12:32

MrCyjaneK reviewed Apr 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: migrate Trade data to SQLite with TradeLegacy for backward compatibility#3106

feat: migrate Trade data to SQLite with TradeLegacy for backward compatibility#3106
Blazebrain wants to merge 6 commits intodevfrom
CW-1423-Migrate-Trade-Object-To-SQLite

Blazebrain commented Mar 18, 2026

Uh oh!

OmarHatem28 Mar 23, 2026

Uh oh!

OmarHatem28 Mar 23, 2026

Uh oh!

OmarHatem28 Mar 23, 2026

Uh oh!

OmarHatem28 Mar 23, 2026

Uh oh!

OmarHatem28 Mar 24, 2026

Uh oh!

MrCyjaneK Apr 16, 2026

Uh oh!

MrCyjaneK Apr 16, 2026

Uh oh!

MrCyjaneK Apr 16, 2026

Uh oh!

MrCyjaneK Apr 16, 2026

Uh oh!

MrCyjaneK Apr 16, 2026

Uh oh!

MrCyjaneK Apr 16, 2026

Uh oh!

MrCyjaneK Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		fromRaw INTEGER NOT NULL DEFAULT -1,
		toRaw INTEGER NOT NULL DEFAULT -1,


		static bool _hasValidString(String? value) => value != null && value.trim().isNotEmpty;

		void mergeFindTradeByIdResult(Trade updated) {


		import 'package:cw_core/crypto_currency.dart';

		class TradeCurrencySnapshot {

Conversation

Blazebrain commented Mar 18, 2026

Description

Pull Request - Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants