ceph-dev-cron: Convert to groovy, trigger ceph-dev-pipeline instead

[djgalloway]

[dmick]

going to look at more but yeah, what's happening with the sha1 business would be a great framework for understanding the code

[dmick]

other than being worried about state management, this seems simple and now understandable with the comments

[djgalloway]

@zmc ping

[zmc]

This looks good to me, only have one non-blocking suggestion about log output.

[zmc]

I think that if the log message mentions parameter values, we should also use them explicitly below, to avoid confusion if e.g. ceph-dev-pipeline defaults change.

[djgalloway]

Fair enough, here's the only change in the force push

diff --git a/ceph-dev-cron/build/Jenkinsfile b/ceph-dev-cron/build/Jenkinsfile
index 1e391664..7420658a 100644
--- a/ceph-dev-cron/build/Jenkinsfile
+++ b/ceph-dev-cron/build/Jenkinsfile
@@ -121,11 +121,13 @@ node('built-in') {
           def winDistros   = toks.findAll { it == 'windows' }.join(' ')
     
           if (linuxDistros) {
-            echo "Triggering BRANCH=${b}, DISTROS=${linuxDistros}, FLAVOR=default, ARCH=x86_64"
+            echo "Triggering BRANCH=${b}, DISTROS=${linuxDistros}, FLAVORS=default, ARCHS=x86_64"
             build job: 'ceph-dev-pipeline',
                   parameters: [
                     string(name: 'BRANCH',    value: b),
                     string(name: 'DISTROS',   value: linuxDistros),
+                    string(name: 'FLAVORS',   value: 'default'),
+                    string(name: 'ARCHS',     value: 'x86_64'),
                     string(name: 'CEPH_REPO', value: repoUrl),
                     string(name: 'SETUP_JOB', value: 'ceph-source-dist'),
                     booleanParam(name: 'FORCE', value: true)
@@ -134,11 +136,13 @@ node('built-in') {
           }
     
           if (winDistros) {
-            echo "Triggering BRANCH=${b}, DISTROS=${winDistros}, FLAVOR=default, ARCH=x86_64"
+            echo "Triggering BRANCH=${b}, DISTROS=${winDistros}, FLAVOR=default, ARCHS=x86_64"
             build job: 'ceph-dev',
                   parameters: [
                     string(name: 'BRANCH',    value: b),
                     string(name: 'DISTROS',   value: winDistros),
+                    string(name: 'FLAVOR',    value: 'default'),
+                    string(name: 'ARCHS',     value: 'x86_64'),
                     booleanParam(name: 'FORCE', value: true)
                   ],
                   wait: false
@@ -146,7 +150,7 @@ node('built-in') {
     
           // This block is for FLAVOR=debug and/or ARCHS=arm64
           cfg[b].extras.each { ex ->
-            echo "Triggering BRANCH=${b}, FLAVOR=${ex.flavors}, ARCH=${ex.archs}"
+            echo "Triggering BRANCH=${b}, FLAVORS=${ex.flavors}, ARCHS=${ex.archs}"
             build job: 'ceph-dev-pipeline',
                   parameters: [
                     string(name: 'BRANCH',    value: b),