Skip to content

Add accounts.google.com to CSP#928

Open
bluikko wants to merge 1 commit intoceph:mainfrom
bluikko:patch-2
Open

Add accounts.google.com to CSP#928
bluikko wants to merge 1 commit intoceph:mainfrom
bluikko:patch-2

Conversation

@bluikko
Copy link
Copy Markdown
Contributor

@bluikko bluikko commented Sep 4, 2025

Attempt to make calendar embed work in all cases.

(maybe) Fixes #927.

Attempt to make calendar embed work in all cases. (maybe) Fixes ceph#927.
@ceph-jenkins
Copy link
Copy Markdown

Can one of the admins verify this patch?

@bluikko
Copy link
Copy Markdown
Contributor Author

bluikko commented Sep 4, 2025

A more complex, and possibly clean, solution might be to add a separate frame-src to the CSP and move all the calendar iframe things there so that the default-src stays clean.
This is definitely not my area of expertise so I can't say how exactly this would behave without looking in detail to the CSP specs (which is a rather complex thing IIRC) but the dev console error message seems to hint this.

@bluikko
Copy link
Copy Markdown
Contributor Author

bluikko commented Apr 21, 2026

I'm not sure what the README section tries to say with:

However, only those belonging to the GitHub Ceph organization can trigger the "Compiling Site" check, which is required for the pull request to merge. Those who do not belong to the GitHub Ceph organization will not be able to trigger the "Compiling Site" check and will be blocked from merging any changes.

I am not seeing any checks/actions run or available for approval for run. But I still seem to have permissions for doing a merge.

It also skips over deployment section. Could you advise on the next steps: is it OK to just merge this, are you able to me point to someone who I should talk to, or wait for someone in the relevant team to proceed?

Edit: I'll ask on the Slack channel actually.

@ljflores ljflores requested a review from djgalloway April 24, 2026 18:14
@djgalloway
Copy link
Copy Markdown
Contributor

ok to test

@djgalloway
Copy link
Copy Markdown
Contributor

jenkins test

@ceph-jenkins
Copy link
Copy Markdown

Site built/updated successfully! https://patch-2.ceph.io

@djgalloway
Copy link
Copy Markdown
Contributor

@bluikko I just pushed this to the nginx config. Does it resolve your issue?

@bluikko
Copy link
Copy Markdown
Contributor Author

bluikko commented Apr 25, 2026

@bluikko I just pushed this to the nginx config. Does it resolve your issue?

It does, thank you. I no longer need to use an Incognito window and the calendar works while Chrome is logged in to a Google account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Community calendar content blocked in some cases

4 participants