allow SINGLE_WRITER to support ReadWriteOncePod#52
Merged
Conversation
|
This change seems appropriate after looking at it in context. I will pass this up to the team and make sure there is nothing else we need to change to make this work properly, but I don't see much that this can affect negatively at the moment. Thank you for the PR! |
hlts2
approved these changes
Nov 17, 2025
Member
There was a problem hiding this comment.
Hi @ddollar , thank you for creating this PR. I’ve reviewed the code changes, and they look fine. Therefore, I have approved this PR—thank you!
Regarding the error you encountered, resolving it will require updating the versions of some dependent plugins. This will need separate testing, so please bear with us a little while longer until a fix is ready. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to use the
ReadWriteOncePodaccess mode for aPersistentVolumeClaimThis should be exactly like
ReadWriteOncebut can only be mounted once per pod. WithReadWriteOncetwo pods on the same node could both write to the same volume, which would be not a good thing for many use cases such as databases.I tried making this change and rolling a custom civo-csi image in my Civo cluster but I got the following error when trying to create the PVC