crypto/tls: add ECH provider rejection unit tests#192
Open
Abhicodeitout wants to merge 1 commit intocloudflare:cffrom
Open
crypto/tls: add ECH provider rejection unit tests#192Abhicodeitout wants to merge 1 commit intocloudflare:cffrom
Abhicodeitout wants to merge 1 commit intocloudflare:cffrom
Conversation
Signed-off-by: Abhishek Kumar Kushwaha <abhithegabbar@gmail.com>
Author
|
@benburkert @evanphx @bmizerany can you review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add unit tests for ECH provider rejection behavior when the client-facing server receives malformed GREASE-like or unsupported algorithm combinations.
What changed
Why
A reviewer suggestion on #95 asked for explicit coverage that the client-facing server rejects:
These tests lock in the intended reject path for both cases.
Verification
Executed with repository toolchain:
GOROOT=/workspaces/go ../bin/go test crypto/tls -run TestECHProvider -count=1 -v
Result: PASS, including both new subtests.
Commit
Includes Signed-off-by: Abhishek Kumar Kushwaha abhithegabbar@gmail.com.