feat: add suppress_pre_request_error_log#862
Open
im-vinicius wants to merge 1 commit intocloudflare:mainfrom
Open
feat: add suppress_pre_request_error_log#862im-vinicius wants to merge 1 commit intocloudflare:mainfrom
suppress_pre_request_error_log#862im-vinicius wants to merge 1 commit intocloudflare:mainfrom
Conversation
Collaborator
|
We are also thinking about something like this internally but more generic for other error call sites, will evaluate how this might fit in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #321.
Adds
suppress_pre_request_error_log(&HttpSession, &Error)for downstream request read/parse failures beforeSelf::CTXis created. This mirrorssuppress_error_logfor the pre-request path.Edit: CI runs are broken, I will rebase this branch once #863 is merged.