Parse existentials in annotations#11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for parsing existential quantifiers in annotation formulas, enabling specifications like exists x:int. result == 2 * x. The implementation extends both the parser and the core CHC (Constrained Horn Clauses) representation.
- Adds new
Formula::Existsvariant andTerm::FormulaExistentialVarto support existentially quantified variables - Implements parsing logic for
existssyntax with variable declarations and sort annotations - Integrates existential handling across CHC utilities (unboxing, SMT-LIB2 formatting, and context)
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ui/pass/annot_exists.rs | Test case verifying correct parsing and verification of existential postconditions |
| tests/ui/fail/annot_exists.rs | Test case verifying detection of unsatisfiable existential postconditions |
| src/chc.rs | Adds Formula::Exists and Term::FormulaExistentialVar variants with supporting methods |
| src/annot.rs | Implements parse_exists and parse_sort methods to handle existential quantifier syntax |
| src/chc/unbox.rs | Extends unboxing transformation to handle new existential variants |
| src/chc/smtlib2.rs | Adds SMT-LIB2 formatting for existential formulas and variables |
| src/chc/format_context.rs | Handles existential variables in sort collection |
| .github/workflows/ci.yml | Configures Docker-based solver (thrust-pcsat-wrapper) for CI testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
coord-e
force-pushed
the
existential-in-annot
branch
from
b27f79a to
5fce671
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
coord-e
force-pushed
the
existential-in-annot
branch
from
5fce671 to
9a6a2b7
Compare
coeff-aij
pushed a commit
to coeff-aij/thrust
that referenced
this pull request
Jan 12, 2026
Parse existentials in annotations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.