Enable to handle some promoted constants#12
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors constant handling to support promoted constants by moving the logic from Env::operand_type() to the Analyzer struct in basic_block.rs. The implementation is decomposed into three helper methods for better maintainability and adds support for handling unevaluated constants.
- Moves constant handling from
env.rstobasic_block.rsfor better access to type context - Adds support for promoted constants via
const_eval_resolve - Introduces
PlaceType::immut()method for creating immutable pointer types
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/refine/env.rs | Removes operand_type method, unused imports, and adds new immut() helper method |
| src/analyze/basic_block.rs | Implements three new methods (const_bytes_ty, const_value_ty, const_ty) for handling constants and refactors operand_type to use them |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9ec096e to
762cfab
Compare
coeff-aij
pushed a commit
to coeff-aij/thrust
that referenced
this pull request
Jan 12, 2026
Enable to handle some promoted constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #10