Skip to content

Fix invalid mfa validation if value was nil#149

Open
pnezis wants to merge 1 commit intodashbitco:mainfrom
pnezis:mfa-nil
Open

Fix invalid mfa validation if value was nil#149
pnezis wants to merge 1 commit intodashbitco:mainfrom
pnezis:mfa-nil

Conversation

@pnezis
Copy link
Copy Markdown
Contributor

@pnezis pnezis commented Mar 11, 2026

iex(1)> schema = [foo: [type: :mfa]]
[foo: [type: :mfa]]
iex(2)> NimbleOptions.validate([foo: nil], schema)
{:ok, [foo: nil]}

@whatyouhide
Copy link
Copy Markdown
Collaborator

I’m surprised that that specific check was there! Have you dug through the blame here?

@pnezis
Copy link
Copy Markdown
Contributor Author

pnezis commented Mar 11, 2026

it's there since the first commit :-)

0ed1d7a#diff-7fb09bff37767b08039f2861a5b0deb150b2a95f29e41746ae719196f9880e70

@whatyouhide
Copy link
Copy Markdown
Collaborator

@josevalim any idea? I’m good with this change to be clear, just want to make sure we're not breaking something or missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants