fix(monitoring): limit jaeger-all-in-one in-memory trace storage to prevent OOM#17171
Open
rohansun wants to merge 1 commit intodatahub-project:masterfrom
Open
fix(monitoring): limit jaeger-all-in-one in-memory trace storage to prevent OOM#17171rohansun wants to merge 1 commit intodatahub-project:masterfrom
rohansun wants to merge 1 commit intodatahub-project:masterfrom
Conversation
github-actions
Bot
added
the
devops
Contributor
|
Linear: PFP-3508 Thanks for your contribution! We have created an internal ticket to track this PR. A member of the core DataHub team will be assigned to review it within the next few business days - you will get a follow-up comment once a reviewer is assigned. |
github-actions
Bot
added
the
community-contribution
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bundle ReportBundle size has no change ✅ |
maggiehays
added
the
needs-review
Contributor
|
Your PR has been assigned to @david-leifker (david.leifker) for review (PFP-3508). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
jaeger-all-in-onecontainer runs with no limit on the number of traces stored in its in-memory storage, which can lead to OOM and crash the host machine.According to Jaeger’s official documentation, the in-memory storage has no default limit on the number of traces stored.
Fix
Added the
MEMORY_MAX_TRACES=100000environment variable to cap the number of traces stored in memory.This value is based on the
max-tracesparameter example from Jaeger’s official documentation.The
MEMORY_MAX_TRACESenvironment variable is derived from the--memory.max-tracesCLI flag by changing all letters to upper-case and replacing all punctuation characters with the underscore, per Jaeger's environment variable naming convention.